TK-NUKE: Potential bug

pritish.pixomondo · September 24, 2019, 1:09am

Hi

This line is calling a function called tk_nuke.sgtk_on_load_callback()

shotgunsoftware/tk-nuke/blob/b6008b51509dcd5c04d4a146a3d31e7b3fa122ca/plugins/basic/Python/tk_nuke_basic/plugin_bootstrap.py#L334




        self._logger.debug(
            "Changing the engine context to: %s", (repr(context)))
        engine.change_context(context)


        # as we have a previous context, this means a new Nuke session has been spawned from the old one
        # and as the asynchronous bootstrap doesn't register the onscriptload callback in time to actually catch the
        # loading of the new script, we should call it manually. The method will also handle the situation where
        # new file is called and there is no path to gather context from.
        import tk_nuke
        tk_nuke.sgtk_on_load_callback()


def _on_failure(self, phase, exception):
    """
    Called when something went wrong during bootstrap.


    :param phase: Phase which went wrong.
    :param exception: Exception that was raised.
    """
    try:
        nuke.error("Initialization failed: %s" % str(exception))

However that function is not there in the init.py file.

Is it referring to the __sgtk_on_load_callback by any chance?

init_.py

philip.scadding · September 24, 2019, 8:32am

ugh yes, you are quite right. I don’t know how that one slipped through.
Thank you for raising that!
I’ve created a PR; I’ll try and get this released.

Best
Phil

pritish.pixomondo · October 2, 2019, 10:23pm

Thanks for the release

There is another bug here

https://github.com/shotgunsoftware/tk-nuke/blob/c8d282b3c4921bee7ea7ffdf2ee3a98dcf04f2e3/python/tk_nuke/init.py#L250

The code should look like this

Otherwise it spits out a warning name 'g_tank_callbacks_registered' is assigned to before global declaration

I will patch it at our end for now, but I thought to let you know.

philip.scadding · October 3, 2019, 5:51am

Thanks! When did that throw an error for you?
I’m just wondering what we were doing differently in our testing to avoid hitting that.

pritish.pixomondo · October 3, 2019, 3:57pm

Hi

If you open up the script editor you can see the error message

Cheers

Pritish

philip.scadding · October 4, 2019, 3:40pm

Hi Pritish

Just to let you know, I’ve released a fix for the original error you reported.
The new tk-nuke version is now v0.12.3.

Regarding the second error you reported, I’m not able to replicate this. I’ve looked in the script editor inside Nuke after launch and even after the launch of a second Nuke instance caused by opening a file via the Nuke menu when a file is already open.

pritish.pixomondo · October 7, 2019, 7:12pm

Here is the traceback from the script editor

Checking tk-framework-widget v0.2.7 (7 of 7).

Resolving context...

Launching Engine...

<PATH_TO_BUNDLECACHE>\tk-nuke\v0.12.2\python\tk_nuke\__init__.py:250: SyntaxWarning: name 'g_tank_callbacks_registered' is assigned to before global declaration

global g_tank_callbacks_registered

Engine launched.